Metrics filter is broken

Description

Metrics filter does not flush aggregated metrics. it seems that Logstash::FilterWorker is not instantiated and therefore flush logic is never executed.

Activity

Show:
Richard Pijnenburg
September 4, 2013, 10:17 AM

Could you run Logstash with the -vv option behind it and try it?
it should give some debuging output then.

Avishai Ish-Shalom
September 4, 2013, 10:41 AM

i did, then i reviewed the code. the problem is that metric events are generated using the `flush` method which is never called.

Bernd Ahlers
October 2, 2013, 11:46 PM

Confirmend. Looks like this got lost during the agent -> agent2 migration in commit https://github.com/logstash/logstash/commit/9542246.

Bernd Ahlers
October 3, 2013, 12:15 PM

I created a pull request to restore the periodic filter flush thread.

See: https://github.com/logstash/logstash/pull/689

Jason Kendall
March 17, 2014, 3:20 PM

PR merged - Closing.

Fixed

Assignee

Logstash Developers

Reporter

Avishai Ish-Shalom

Labels

None

Affects versions

Configure