GeoIP filter does not save GeoJSON as advertised in the changelog

Description

according to the changelog, the geoip filter has a 'new setting 'add_geojson' (default true) and geojson_name (default 'location') to write a GeoJSON-friendly coordinate to your event'. However in the documentation these options aren't visible. And when I look at the code in 'lib/logstash/filters/geoip.rb', these options are neither declared nor used. The geoJSON info is added if the event contains a latitude and a longitude key.

I'm currently testing a patch I created to rectify this issue.

Activity

Show:
Aaron Mildenstein
December 13, 2013, 6:19 PM

As mentioned in commends on #874:

```
Thank you for catching what I failed to clean up. :+1:

I had originally had it configurable, as your patch puts back in. But we decided we didn't want or need the extra options and removed the code. I just forgot to clean up the configuration options and documentation with them.
```

Will edit CHANGELOG to reflect this as well.

Brad Fritz
December 17, 2013, 5:38 PM

Love to see documentation improvements. Thanks, Pieter!

I added a few more to fix some very minor issues including markdown escaping:
https://github.com/logstash/logstash/pull/883

Brad Fritz
December 17, 2013, 5:40 PM

Probably worth mentioning that you can preview the changes with something like:

Handy for catching markdown problems.

Aaron Mildenstein
December 17, 2013, 5:41 PM

MERGED again! Thank you!

Philippe Weber
February 5, 2014, 11:59 AM

PR merged!

Assignee

Aaron Mildenstein

Reporter

Pieter Lexis

Fix versions

Affects versions

Configure